On Thu, Feb 07, 2019 at 03:23:21PM +0200, Alberto Garcia wrote: > After g_source_attach() the GMainContext holds a reference to the > GSource, so the caller does not need to keep it. > > pty_chr_state() and qio_task_thread_worker() are not doing this, so > the GSource is being leaked in both cases (pty_chr_open_src_cancel() > is the exception here because it does remove the extra reference > correctly). > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > chardev/char-pty.c | 2 +- > io/task.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
