On Thu, Feb 07, 2019 at 03:29:35PM +0200, Samuel Thibault wrote: > Peter Maydell, le jeu. 07 févr. 2019 11:46:23 +0000, a ecrit: > > On Tue, 5 Feb 2019 at 18:28, Samuel Thibault > > <samuel.thiba...@ens-lyon.org> wrote: > > > > > > The following changes since commit > > > 01a9a51ffaf4699827ea6425cb2b834a356e159d: > > > > > > Merge remote-tracking branch > > > 'remotes/kraxel/tags/ui-20190205-pull-request' into staging (2019-02-05 > > > 14:01:29 +0000) > > > > > > are available in the Git repository at: > > > > > > https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault > > > > > > for you to fetch changes up to 1e924479dce65a26a7432bf5920f89c1bf957d74: > > > > > > slirp: API is extern C (2019-02-05 20:27:27 +0200) > > > > > > ---------------------------------------------------------------- > > > More work towards libslirp > > > > > > > Format string issues for the Windows build: > > Oh, I am not getting these errors with make docker-test-mingw@fedora, > perhaps something would need to be fixed there to test as much as you do?
You're seeing a difference due to the version of glib2 that's built. Previously the GLIB_*_FORMAT macros would contain the win32 platform specific formats, and the g_critical function would be annotated with 'printf'. Now GLib2's GLIB_*_FORMAT macros will contain the GNU compatible formats, and the g_critical function would be annotated 'gnu_printf'. So your Fedora build test used the gnu_printf based glib2 and so didn't trigger the warnings. Peter's build probably uses an older glib. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|