Eric Blake <ebl...@redhat.com> writes: > On 2/6/19 12:17 PM, Markus Armbruster wrote: >> We can't add appropriate target-specific conditionals to misc.json, >> because that would make all of misc.json unusable in >> target-independent code. To keep misc.json target-independent, we >> need to split off target-dependent target.json. >> >> This commit doesn't actually split off anything, it merely creates the >> empty module. The next few patches will move stuff from misc.json >> there. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> Makefile.objs | 20 +++++++++----------- >> Makefile.target | 10 ++++++++++ >> qapi/qapi-schema.json | 1 + >> qapi/target.json | 13 +++++++++++++ >> 4 files changed, 33 insertions(+), 11 deletions(-) >> create mode 100644 qapi/target.json > >> +++ b/Makefile.target >> @@ -164,6 +164,16 @@ endif >> >> GENERATED_FILES += hmp-commands.h hmp-commands-info.h >> >> +# FIXME duplicates Makefile.obj's > > Is this addressed later in the series, or should the commit message call > it out?
It's not addressed. I added the FIXME for my RFC v2, which went out in a bit of a hurry right before my Christmas break. I promptly forgot it exists. Either I find a way to avoid the duplication, or I mention the FIXME in my commit message. Thanks! >> +QAPI_TARGET_MODULES = target >> +obj-y += $(QAPI_TARGET_MODULES:%=qapi/qapi-types-%.o) >> +obj-y += qapi/qapi-types.o >> +obj-y += $(QAPI_TARGET_MODULES:%=qapi/qapi-visit-%.o) >> +obj-y += qapi/qapi-visit.o >> +obj-y += $(QAPI_TARGET_MODULES:%=qapi/qapi-events-%.o) >> +obj-y += qapi/qapi-events.o >> +obj-y += $(QAPI_TARGET_MODULES:%=qapi/qapi-commands-%.o) >> +obj-y += qapi/qapi-commands.o >> obj-y += qapi/qapi-introspect.o >>
