On 2019-02-11 12:32, Cornelia Huck wrote: > We tried to make pci support optional on s390x in the past; > unfortunately, we still require the s390 phb to be created > unconditionally due to backwards compatibility issues. > > Instead of sinking more effort into this (including compat > handling for older machines etc.) for non-obvious gains, let's > just make CONFIG_PCI something that is always set on s390x. > > Note that you can still fence off pci for the _guest_ if you > provide a cpu model without the zpci feature. > > Signed-off-by: Cornelia Huck <coh...@redhat.com> > --- > Follow-up patch to the discussion around "hw/s390x: Fix the function > arguments in the pci stub file". I've done a quick sanity test with > tcg only so far. > --- > hw/s390x/Makefile.objs | 3 +- > hw/s390x/s390-pci-stub.c | 77 ------------------------------------- > hw/s390x/s390-virtio-ccw.c | 4 -- > target/s390x/cpu_models.c | 5 --- > target/s390x/gen-features.c | 1 - > target/s390x/kvm.c | 4 +- > 6 files changed, 2 insertions(+), 92 deletions(-) > delete mode 100644 hw/s390x/s390-pci-stub.c
Reviewed-by: Thomas Huth <th...@redhat.com>
