Patchew URL: https://patchew.org/QEMU/20190212160953.29051-1-marcandre.lur...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/2] Fix slirp regression on win32 Type: series Message-id: 20190212160953.29051-1-marcandre.lur...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 8efa2500fe slirp: wrap the remaining socket functions 6db690637f slirp: remove slirp_ prefix for socket wrappers === OUTPUT BEGIN === 1/2 Checking commit 6db690637f48 (slirp: remove slirp_ prefix for socket wrappers) ERROR: code indent should never use tabs #115: FILE: slirp/socket.c:188: +^Inn = recv(so->s, iov[0].iov_base, iov[0].iov_len,0);$ ERROR: space required after that ',' (ctx:VxV) #115: FILE: slirp/socket.c:188: + nn = recv(so->s, iov[0].iov_base, iov[0].iov_len,0); ^ ERROR: code indent should never use tabs #124: FILE: slirp/socket.c:204: +^I^I^I^I^Igetsockopt(so->s, SOL_SOCKET, SO_ERROR,$ ERROR: space required after that ',' (ctx:VxV) #133: FILE: slirp/socket.c:234: + ret = recv(so->s, iov[1].iov_base, iov[1].iov_len,0); ^ ERROR: code indent should never use tabs #142: FILE: slirp/socket.c:555: +^I ioctlsocket(so->s, FIONREAD, &n);$ ERROR: code indent should never use tabs #160: FILE: slirp/socket.c:738: +^Isetsockopt(s, SOL_SOCKET, SO_OOBINLINE, &opt, sizeof(int));$ ERROR: code indent should never use tabs #163: FILE: slirp/socket.c:740: +^Isetsockopt(s, IPPROTO_TCP, TCP_NODELAY, &opt, sizeof(int));$ ERROR: code indent should never use tabs #176: FILE: slirp/tcp_subr.c:340: +^Iclosesocket(so->s);$ ERROR: code indent should never use tabs #219: FILE: slirp/udp.c:295: +^Iclosesocket(so->s);$ total: 9 errors, 0 warnings, 212 lines checked Patch 1/2 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/2 Checking commit 8efa2500febb (slirp: wrap the remaining socket functions) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190212160953.29051-1-marcandre.lur...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com