On 2/14/19 9:24 AM, Markus Armbruster wrote: > Diff from v4: > > +++ b/qapi/Makefile.objs > @@ -18,8 +18,9 @@ util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-visit-%.o) > util-obj-y += qapi-emit-events.o > util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-events-%.o) > > -common-obj-y += $(QAPI_COMMON_MODULES:%=qapi-commands-%.o) > +common-obj-y = $(QAPI_COMMON_MODULES:%=qapi-commands-%.o)
In other situations, use of = instead of += has resulted in inadvertent omission of files. Should we just always use +=, rather than having to remember to audit if the use of = is not overriding earlier lines? > > +obj-y = qapi-introspect.o and again > obj-y += $(QAPI_TARGET_MODULES:%=qapi-types-%.o) > obj-y += qapi-types.o > obj-y += $(QAPI_TARGET_MODULES:%=qapi-visit-%.o) > @@ -28,4 +29,3 @@ obj-y += $(QAPI_TARGET_MODULES:%=qapi-events-%.o) > obj-y += qapi-events.o > obj-y += $(QAPI_TARGET_MODULES:%=qapi-commands-%.o) > obj-y += qapi-commands.o > -obj-y += qapi-introspect.o > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature