Patchew URL: https://patchew.org/QEMU/20190214190603.25030-1-peter.mayd...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/27] target-arm queue Message-id: 20190214190603.25030-1-peter.mayd...@linaro.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190214102816.3393-1-peter.mayd...@linaro.org -> patchew/20190214102816.3393-1-peter.mayd...@linaro.org - [tag update] patchew/20190214190603.25030-1-peter.mayd...@linaro.org -> patchew/20190214190603.25030-1-peter.mayd...@linaro.org Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/u-boot-sam460ex'... Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588' Cloning into 'tests/fp/berkeley-softfloat-3'... Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'tests/fp/berkeley-testfloat-3'... Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' 8fd00e6 gdbstub: Send a reply to the vKill packet. 34aa54e target/arm: Add missing clear_tail calls 3846dbe target/arm: Use vector operations for saturation 781e41b target/arm: Split out FPSCR.QC to a vector field 95ef691 target/arm: Fix set of bits kept in xregs[ARM_VFP_FPSCR] d640c73 target/arm: Split out flags setting from vfp compares a556351 target/arm: Fix arm_cpu_dump_state vs FPSCR 6e9dcb5 target/arm: Fix vfp_gdb_get/set_reg vs FPSCR bd99640 target/arm: Remove neon min/max helpers 5246212 target/arm: Use tcg integer min/max primitives for neon 28d1ed9 target/arm: Use vector minmax expanders for aarch32 f835440 target/arm: Use vector minmax expanders for aarch64 2fc345a target/arm: Rely on optimization within tcg_gen_gvec_or 5aafc65 hw/arm/armsse: Fix miswiring of expansion IRQs c85153c hw/intc/armv7m_nvic: Allow byte accesses to SHPR1 4ec0189 MAINTAINERS: Remove Peter Crosthwaite from various entries 45ab292 arm: Allow system registers for KVM guests to be changed by QEMU code 3382e5f linux-user/elfload: enable HWCAP_CPUID for AArch64 1d9bc81 target/arm: expose remaining CPUID registers as RAZ ba7bf1b target/arm: expose MPIDR_EL1 to userspace 9ee0c2a target/arm: expose CPUID registers to userspace a443302 target/arm: relax permission checks for HWCAP_CPUID registers f59f8c9 target/arm: Restructure disas_fp_int_conv e9d6907 target/arm: Force result size into dp after operation aeaa89a target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be 7124a83 target/arm: Implement HACR_EL2 8820060 target/arm: Fix CRn to be 14 for PMEVTYPER/PMEVCNTR === OUTPUT BEGIN === 1/27 Checking commit 88200603a8cb (target/arm: Fix CRn to be 14 for PMEVTYPER/PMEVCNTR) 2/27 Checking commit 7124a830e497 (target/arm: Implement HACR_EL2) 3/27 Checking commit aeaa89ad8291 (target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be) 4/27 Checking commit e9d6907528aa (target/arm: Force result size into dp after operation) 5/27 Checking commit f59f8c968ae5 (target/arm: Restructure disas_fp_int_conv) 6/27 Checking commit a44330292615 (target/arm: relax permission checks for HWCAP_CPUID registers) 7/27 Checking commit 9ee0c2aab31c (target/arm: expose CPUID registers to userspace) 8/27 Checking commit ba7bf1bc03e1 (target/arm: expose MPIDR_EL1 to userspace) 9/27 Checking commit 1d9bc813e57b (target/arm: expose remaining CPUID registers as RAZ) 10/27 Checking commit 3382e5fb3a55 (linux-user/elfload: enable HWCAP_CPUID for AArch64) 11/27 Checking commit 45ab2928675e (arm: Allow system registers for KVM guests to be changed by QEMU code) 12/27 Checking commit 4ec0189e9352 (MAINTAINERS: Remove Peter Crosthwaite from various entries) 13/27 Checking commit c85153c2d903 (hw/intc/armv7m_nvic: Allow byte accesses to SHPR1) 14/27 Checking commit 5aafc658edab (hw/arm/armsse: Fix miswiring of expansion IRQs) 15/27 Checking commit 2fc345aa780c (target/arm: Rely on optimization within tcg_gen_gvec_or) 16/27 Checking commit f8354404a2f8 (target/arm: Use vector minmax expanders for aarch64) 17/27 Checking commit 28d1ed93b13a (target/arm: Use vector minmax expanders for aarch32) 18/27 Checking commit 524621238d29 (target/arm: Use tcg integer min/max primitives for neon) 19/27 Checking commit bd9964085387 (target/arm: Remove neon min/max helpers) 20/27 Checking commit 6e9dcb58eb81 (target/arm: Fix vfp_gdb_get/set_reg vs FPSCR) ERROR: trailing statements should be on next line #25: FILE: target/arm/helper.c:84: + case 1: stl_p(buf, vfp_get_fpscr(env)); return 4; ERROR: trailing statements should be on next line #34: FILE: target/arm/helper.c:110: + case 1: vfp_set_fpscr(env, ldl_p(buf)); return 4; total: 2 errors, 0 warnings, 16 lines checked Patch 20/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/27 Checking commit a5563518a586 (target/arm: Fix arm_cpu_dump_state vs FPSCR) 22/27 Checking commit d640c730a965 (target/arm: Split out flags setting from vfp compares) 23/27 Checking commit 95ef6915a6d0 (target/arm: Fix set of bits kept in xregs[ARM_VFP_FPSCR]) 24/27 Checking commit 781e41b075a0 (target/arm: Split out FPSCR.QC to a vector field) 25/27 Checking commit 3846dbef44da (target/arm: Use vector operations for saturation) ERROR: spaces required around that '*' (ctx:WxV) #360: FILE: target/arm/vec_helper.c:774: + TYPEN *d = vd, *n = vn; TYPEM *m = vm; \ ^ total: 1 errors, 0 warnings, 438 lines checked Patch 25/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/27 Checking commit 34aa54edfa31 (target/arm: Add missing clear_tail calls) 27/27 Checking commit 8fd00e6381cf (gdbstub: Send a reply to the vKill packet.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190214190603.25030-1-peter.mayd...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com