Patchew URL: https://patchew.org/QEMU/20190215143115.28777-1-alex.ben...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190215143115.28777-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v3 0/3] softmmu demacro Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190215133005.15955-1-da...@redhat.com -> patchew/20190215133005.15955-1-da...@redhat.com * [new tag] patchew/20190215143115.28777-1-alex.ben...@linaro.org -> patchew/20190215143115.28777-1-alex.ben...@linaro.org Switched to a new branch 'test' e26497c4c1 accel/tcg: move unaligned helpers out of core helpers bb7a57bffb accel/tcg: remove softmmu_template.h 3a3cfc0d92 accel/tcg: demacro cputlb === OUTPUT BEGIN === 1/3 Checking commit 3a3cfc0d9223 (accel/tcg: demacro cputlb) 2/3 Checking commit bb7a57bffbe0 (accel/tcg: remove softmmu_template.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: deleted file mode 100644 total: 0 errors, 1 warnings, 0 lines checked Patch 2/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/3 Checking commit e26497c4c1e5 (accel/tcg: move unaligned helpers out of core helpers) ERROR: externs should be avoided in .c files #29: FILE: accel/tcg/cputlb.c:1210: +tcg_target_ulong load_helper(CPUArchState *env, target_ulong addr, WARNING: line over 80 characters #34: FILE: accel/tcg/cputlb.c:1215: +static tcg_target_ulong unaligned_load_helper(CPUArchState *env, target_ulong addr, ERROR: externs should be avoided in .c files #199: FILE: accel/tcg/cputlb.c:1443: +void store_helper(CPUArchState *env, target_ulong addr, uint64_t val, WARNING: line over 80 characters #246: FILE: accel/tcg/cputlb.c:1509: + unaligned_store_helper(env, addr, val, oi, retaddr, size, big_endian); total: 2 errors, 2 warnings, 381 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190215143115.28777-1-alex.ben...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
