Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190218125615.18970-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190218125615.18970-1-arm...@redhat.com -> patchew/20190218125615.18970-1-arm...@redhat.com Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/u-boot-sam460ex'... Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588' Cloning into 'tests/fp/berkeley-softfloat-3'... Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'tests/fp/berkeley-testfloat-3'... Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' 7003d72 hw/arm hw/xtensa: De-duplicate pflash creation code some 0f5bb14 pflash: Clean up after commit 368a354f02b part 2 0ddfc52 pflash: Clean up after commit 368a354f02b part 1 a88cfc5 mips_malta: Clean up definition of flash memory size somewhat 06b58eb r2d: Flash memory creation is confused about size, mark FIXME fd280c6 ppc405_boards: Don't size flash memory to match backing image 85a5bb5 sam460ex: Don't size flash memory to match backing image 4f66728 hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2} 368c510 pflash: Macro PFLASH_BUG() is used just once, expand 209d90e pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02 === OUTPUT BEGIN === 1/10 Checking commit 209d90e8f163 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02) ERROR: space prohibited between function name and open parenthesis '(' #128: FILE: hw/block/pflash_cfi01.c:288: +static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset, ERROR: space prohibited between function name and open parenthesis '(' #340: FILE: hw/block/pflash_cfi02.c:141: +static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset, ERROR: space prohibited between function name and open parenthesis '(' #358: FILE: hw/block/pflash_cfi02.c:264: +static void pflash_write (PFlashCFI02 *pfl, hwaddr offset, total: 3 errors, 0 warnings, 483 lines checked Patch 1/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/10 Checking commit 368c51060aff (pflash: Macro PFLASH_BUG() is used just once, expand) 3/10 Checking commit 4f66728f2f5a (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}) 4/10 Checking commit 85a5bb56ec18 (sam460ex: Don't size flash memory to match backing image) 5/10 Checking commit fd280c6abca7 (ppc405_boards: Don't size flash memory to match backing image) 6/10 Checking commit 06b58eb0a8e9 (r2d: Flash memory creation is confused about size, mark FIXME) 7/10 Checking commit a88cfc5bbf98 (mips_malta: Clean up definition of flash memory size somewhat) 8/10 Checking commit 0ddfc52fb852 (pflash: Clean up after commit 368a354f02b part 1) ERROR: spaces required around that '-' (ctx:VxV) #90: FILE: hw/arm/musicpal.c:1639: + pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX, ^ ERROR: spaces required around that '-' (ctx:VxV) #98: FILE: hw/arm/musicpal.c:1646: + pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX, ^ total: 2 errors, 0 warnings, 248 lines checked Patch 8/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/10 Checking commit 0f5bb148930a (pflash: Clean up after commit 368a354f02b part 2) 10/10 Checking commit 7003d72a5f0f (hw/arm hw/xtensa: De-duplicate pflash creation code some) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190218125615.18970-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com