On 2/25/19 8:59 AM, Vladimir Sementsov-Ogievskiy wrote: > > And one more important question: we now creating new qapi bitmap status, > consisting of several bool fields. > Shouldn't we instead implement it as an array of flags?
Parsing: { "busy": false, "persistent": false, "recording": true } is easier than parsing: { "flags": [ "recording" ] } (and knowing that unlisted flags "busy", "persistent", and "inconsistent" are false), or: { "flags": [ { "busy": false }, { "persistent": false }, { "recording": true } ] } So without more reason why an array of flags would be needed, I don't see the point for it. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org