On 2/28/19 9:35 AM, Aarushi Mehta wrote: > > Signed-off-by: Aarushi Mehta <mehta.aar...@gmail.com> > --- > Note that since thunking occurs throughout the lifetime of the QEMU instance, > there is no matching 'free' to correct
This sentence is vital to the patch, so it belongs above the --- and S-o-b as part of the commit message. > It might be valuable to edit the BiteSizedTasks to reflect that g_new is > favoured over g_malloc And I've done that now, by emphasizing the discussion in HACKING (rather than repeating it on the wiki): https://wiki.qemu.org/index.php?title=Contribute/BiteSizedTasks&diff=8247&oldid=8242 With the improved commit message, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
