Patchew URL: https://patchew.org/QEMU/20190228202537.4638-1-alex.ben...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190228202537.4638-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/16] Enabling tcg/tests for cris and system mode xtensa & arm Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190228202537.4638-1-alex.ben...@linaro.org -> patchew/20190228202537.4638-1-alex.ben...@linaro.org Switched to a new branch 'test' 3817cc66f8 .travis.yml: add softmmu check-tcg tests 5454ef35e8 .travis.yml: separate softfloat from check-tcg 1c72e41070 tests/tcg: enable cris base user-mode tests 74bfebc2ba tests/tcg/cris: align mul operations c156c31322 tests/tcg/cris: comment out the ccs test a85ea55327 tests/tcg/cris: cleanup sys.c 3748808883 tests/tcg: split cris tests into bare and libc directories 057b9b0114 tests/docker: add fedora-cris-cross compilers a0e211db55 tests/tcg/arm: add ARMv6-M UNDEFINED 32-bit instruction test 8dd8472bdd tests/tcg/xtensa: enable system tests 98cf445f43 tests/docker: add debian-xtensa-cross image a98cb156ea tests/tcg/mips: fix hello-mips compilation f87abb1245 tests/tcg: add gdb runner variant 8f6ab4e934 tests/tcg: add QEMU_OPT option for test runner 73feb4fff8 tests/tcg: enable tcg tests for softmmu 05b1080f7b tests/tcg: add softmmu awareness to Makefile === OUTPUT BEGIN === 1/16 Checking commit 05b1080f7b30 (tests/tcg: add softmmu awareness to Makefile) 2/16 Checking commit 73feb4fff8c8 (tests/tcg: enable tcg tests for softmmu) 3/16 Checking commit 8f6ab4e9345c (tests/tcg: add QEMU_OPT option for test runner) 4/16 Checking commit f87abb12456e (tests/tcg: add gdb runner variant) 5/16 Checking commit a98cb156ea9b (tests/tcg/mips: fix hello-mips compilation) 6/16 Checking commit 98cf445f439f (tests/docker: add debian-xtensa-cross image) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 42 lines checked Patch 6/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/16 Checking commit 8dd8472bdd63 (tests/tcg/xtensa: enable system tests) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: deleted file mode 100644 total: 0 errors, 1 warnings, 40 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit a0e211db55c0 (tests/tcg/arm: add ARMv6-M UNDEFINED 32-bit instruction test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 204 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 057b9b0114ea (tests/docker: add fedora-cris-cross compilers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 8 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 37488088838b (tests/tcg: split cris tests into bare and libc directories) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: rename from tests/tcg/cris/check_addcv17.s ERROR: space prohibited between function name and open parenthesis '(' #432: FILE: tests/tcg/cris/libc/sys.c:6: +void exit (int status) { ERROR: code indent should never use tabs #433: FILE: tests/tcg/cris/libc/sys.c:7: +^Iregister unsigned int callno asm ("r9") = 1; /* NR_exit */$ ERROR: code indent should never use tabs #434: FILE: tests/tcg/cris/libc/sys.c:8: +^Iasm volatile ("break 13\n"$ ERROR: code indent should never use tabs #435: FILE: tests/tcg/cris/libc/sys.c:9: +^I^I :$ ERROR: code indent should never use tabs #436: FILE: tests/tcg/cris/libc/sys.c:10: +^I^I : "r" (callno)$ ERROR: code indent should never use tabs #437: FILE: tests/tcg/cris/libc/sys.c:11: +^I^I : "memory" );$ ERROR: space prohibited before that close parenthesis ')' #437: FILE: tests/tcg/cris/libc/sys.c:11: + : "memory" ); ERROR: code indent should never use tabs #438: FILE: tests/tcg/cris/libc/sys.c:12: +^Iwhile(1);$ ERROR: space required before the open parenthesis '(' #438: FILE: tests/tcg/cris/libc/sys.c:12: + while(1); ERROR: trailing statements should be on next line #438: FILE: tests/tcg/cris/libc/sys.c:12: + while(1); ERROR: braces {} are necessary for all arms of this statement #438: FILE: tests/tcg/cris/libc/sys.c:12: + while(1); [...] ERROR: space prohibited between function name and open parenthesis '(' #441: FILE: tests/tcg/cris/libc/sys.c:15: +ssize_t write (int fd, const void *buf, size_t count) { ERROR: code indent should never use tabs #442: FILE: tests/tcg/cris/libc/sys.c:16: +^Iregister unsigned int callno asm ("r9") = 4; /* NR_write */$ ERROR: code indent should never use tabs #443: FILE: tests/tcg/cris/libc/sys.c:17: +^Iregister unsigned int r10 asm ("r10") = fd;$ ERROR: code indent should never use tabs #444: FILE: tests/tcg/cris/libc/sys.c:18: +^Iregister const void *r11 asm ("r11") = buf;$ ERROR: code indent should never use tabs #445: FILE: tests/tcg/cris/libc/sys.c:19: +^Iregister size_t r12 asm ("r12") = count;$ ERROR: code indent should never use tabs #446: FILE: tests/tcg/cris/libc/sys.c:20: +^Iregister unsigned int r asm ("r10");$ ERROR: code indent should never use tabs #448: FILE: tests/tcg/cris/libc/sys.c:22: +^Iasm volatile ("break 13\n"$ ERROR: code indent should never use tabs #449: FILE: tests/tcg/cris/libc/sys.c:23: +^I : "=r" (r)$ ERROR: code indent should never use tabs #450: FILE: tests/tcg/cris/libc/sys.c:24: +^I : "r" (callno), "0" (r10), "r" (r11), "r" (r12)$ ERROR: code indent should never use tabs #451: FILE: tests/tcg/cris/libc/sys.c:25: +^I : "memory");$ ERROR: code indent should never use tabs #453: FILE: tests/tcg/cris/libc/sys.c:27: +^Ireturn r;$ ERROR: open brace '{' following function declarations go on the next line #456: FILE: tests/tcg/cris/libc/sys.c:30: +static inline int mystrlen(char *s) { ERROR: code indent should never use tabs #457: FILE: tests/tcg/cris/libc/sys.c:31: +^Iint i = 0;$ ERROR: code indent should never use tabs #458: FILE: tests/tcg/cris/libc/sys.c:32: +^Iwhile (s[i])$ ERROR: braces {} are necessary for all arms of this statement #458: FILE: tests/tcg/cris/libc/sys.c:32: + while (s[i]) [...] ERROR: code indent should never use tabs #459: FILE: tests/tcg/cris/libc/sys.c:33: +^I^Ii++;$ ERROR: code indent should never use tabs #460: FILE: tests/tcg/cris/libc/sys.c:34: +^Ireturn i;$ ERROR: open brace '{' following function declarations go on the next line #463: FILE: tests/tcg/cris/libc/sys.c:37: +void pass(void) { ERROR: code indent should never use tabs #464: FILE: tests/tcg/cris/libc/sys.c:38: +^Ichar s[] = "passed.\n";$ ERROR: code indent should never use tabs #465: FILE: tests/tcg/cris/libc/sys.c:39: +^Iwrite (1, s, sizeof (s) - 1);$ ERROR: space prohibited between function name and open parenthesis '(' #465: FILE: tests/tcg/cris/libc/sys.c:39: + write (1, s, sizeof (s) - 1); ERROR: space prohibited between function name and open parenthesis '(' #465: FILE: tests/tcg/cris/libc/sys.c:39: + write (1, s, sizeof (s) - 1); ERROR: code indent should never use tabs #466: FILE: tests/tcg/cris/libc/sys.c:40: +^Iexit (0);$ ERROR: space prohibited between function name and open parenthesis '(' #466: FILE: tests/tcg/cris/libc/sys.c:40: + exit (0); ERROR: open brace '{' following function declarations go on the next line #469: FILE: tests/tcg/cris/libc/sys.c:43: +void _fail(char *reason) { ERROR: code indent should never use tabs #470: FILE: tests/tcg/cris/libc/sys.c:44: +^Ichar s[] = "\nfailed: ";$ ERROR: code indent should never use tabs #471: FILE: tests/tcg/cris/libc/sys.c:45: +^Iint len = mystrlen(reason);$ ERROR: code indent should never use tabs #472: FILE: tests/tcg/cris/libc/sys.c:46: +^Iwrite (1, s, sizeof (s) - 1);$ ERROR: space prohibited between function name and open parenthesis '(' #472: FILE: tests/tcg/cris/libc/sys.c:46: + write (1, s, sizeof (s) - 1); ERROR: space prohibited between function name and open parenthesis '(' #472: FILE: tests/tcg/cris/libc/sys.c:46: + write (1, s, sizeof (s) - 1); ERROR: code indent should never use tabs #473: FILE: tests/tcg/cris/libc/sys.c:47: +^Iwrite (1, reason, len);$ ERROR: space prohibited between function name and open parenthesis '(' #473: FILE: tests/tcg/cris/libc/sys.c:47: + write (1, reason, len); ERROR: code indent should never use tabs #474: FILE: tests/tcg/cris/libc/sys.c:48: +^Iwrite (1, "\n", 1);$ ERROR: space prohibited between function name and open parenthesis '(' #474: FILE: tests/tcg/cris/libc/sys.c:48: + write (1, "\n", 1); ERROR: code indent should never use tabs #475: FILE: tests/tcg/cris/libc/sys.c:49: +//^Iexit (1);$ ERROR: do not use C99 // comments #475: FILE: tests/tcg/cris/libc/sys.c:49: +// exit (1); ERROR: space prohibited between function name and open parenthesis '(' #478: FILE: tests/tcg/cris/libc/sys.c:52: +void *memset (void *s, int c, size_t n) { ERROR: code indent should never use tabs #479: FILE: tests/tcg/cris/libc/sys.c:53: +^Ichar *p = s;$ ERROR: code indent should never use tabs #480: FILE: tests/tcg/cris/libc/sys.c:54: +^Iint i;$ ERROR: code indent should never use tabs #481: FILE: tests/tcg/cris/libc/sys.c:55: +^Ifor (i = 0; i < n; i++)$ ERROR: braces {} are necessary for all arms of this statement #481: FILE: tests/tcg/cris/libc/sys.c:55: + for (i = 0; i < n; i++) [...] ERROR: code indent should never use tabs #482: FILE: tests/tcg/cris/libc/sys.c:56: +^I^Ip[i] = c;$ ERROR: code indent should never use tabs #483: FILE: tests/tcg/cris/libc/sys.c:57: +^Ireturn p;$ total: 54 errors, 1 warnings, 58 lines checked Patch 10/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/16 Checking commit a85ea55327a0 (tests/tcg/cris: cleanup sys.c) ERROR: space prohibited before that close parenthesis ')' #47: FILE: tests/tcg/cris/bare/sys.c:16: + : "memory" ); ERROR: space required before the open parenthesis '(' #48: FILE: tests/tcg/cris/bare/sys.c:17: + while(1); ERROR: trailing statements should be on next line #48: FILE: tests/tcg/cris/bare/sys.c:17: + while(1); ERROR: braces {} are necessary for all arms of this statement #48: FILE: tests/tcg/cris/bare/sys.c:17: + while(1); [...] ERROR: space prohibited between function name and open parenthesis '(' #82: FILE: tests/tcg/cris/bare/sys.c:48: + write(1, s, sizeof (s) - 1); ERROR: space prohibited between function name and open parenthesis '(' #129: FILE: tests/tcg/cris/bare/sys.c:55: + write(1, s, sizeof (s) - 1); ERROR: code indent should never use tabs #150: FILE: tests/tcg/cris/libc/sys.c:12: +^I^I : "memory");$ ERROR: code indent should never use tabs #178: FILE: tests/tcg/cris/libc/sys.c:43: +^Iwrite (1, s, sizeof(s) - 1);$ ERROR: space prohibited between function name and open parenthesis '(' #178: FILE: tests/tcg/cris/libc/sys.c:43: + write (1, s, sizeof(s) - 1); total: 9 errors, 0 warnings, 169 lines checked Patch 11/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/16 Checking commit c156c313223c (tests/tcg/cris: comment out the ccs test) 13/16 Checking commit 74bfebc2ba91 (tests/tcg/cris: align mul operations) 14/16 Checking commit 1c72e410701f (tests/tcg: enable cris base user-mode tests) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: deleted file mode 100644 total: 0 errors, 1 warnings, 71 lines checked Patch 14/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/16 Checking commit 5454ef35e853 (.travis.yml: separate softfloat from check-tcg) 16/16 Checking commit 3817cc66f810 (.travis.yml: add softmmu check-tcg tests) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190228202537.4638-1-alex.ben...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
