Patchew URL: https://patchew.org/QEMU/20190301064809.3074-1-llyzs....@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190301064809.3074-1-llyzs....@gmail.com Subject: [Qemu-devel] [PATCH v2] slirp: check for ioctlsocket error and 0-length udp payload. Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190301064809.3074-1-llyzs....@gmail.com -> patchew/20190301064809.3074-1-llyzs....@gmail.com Switched to a new branch 'test' 0987e4851f slirp: check for ioctlsocket error and 0-length udp payload. === OUTPUT BEGIN === ERROR: code indent should never use tabs #23: FILE: slirp/socket.c:532: +^I if (ioctlsocket(so->s, FIONREAD, &n) != 0) {$ ERROR: suspect code indent for conditional statements (10, 14) #23: FILE: slirp/socket.c:532: + if (ioctlsocket(so->s, FIONREAD, &n) != 0) { + DEBUG_MISC((dfd," ioctlsocket errno = %d-%s\n", ERROR: code indent should never use tabs #24: FILE: slirp/socket.c:533: +^I DEBUG_MISC((dfd," ioctlsocket errno = %d-%s\n",$ ERROR: space required after that ',' (ctx:VxV) #24: FILE: slirp/socket.c:533: + DEBUG_MISC((dfd," ioctlsocket errno = %d-%s\n", ^ ERROR: code indent should never use tabs #25: FILE: slirp/socket.c:534: +^I^I^I errno,strerror(errno)));$ ERROR: space required after that ',' (ctx:VxV) #25: FILE: slirp/socket.c:534: + errno,strerror(errno))); ^ ERROR: code indent should never use tabs #26: FILE: slirp/socket.c:535: +^I return;$ ERROR: code indent should never use tabs #27: FILE: slirp/socket.c:536: +^I }$ ERROR: code indent should never use tabs #28: FILE: slirp/socket.c:537: +^I if (n == 0) {$ ERROR: suspect code indent for conditional statements (10, 14) #28: FILE: slirp/socket.c:537: + if (n == 0) { + return; ERROR: code indent should never use tabs #29: FILE: slirp/socket.c:538: +^I return;$ ERROR: code indent should never use tabs #30: FILE: slirp/socket.c:539: +^I }$ total: 12 errors, 0 warnings, 22 lines checked Commit 0987e4851f60 (slirp: check for ioctlsocket error and 0-length udp payload.) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190301064809.3074-1-llyzs....@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
