On 3/2/19 6:36 PM, Samuel Thibault wrote: > Philippe Mathieu-Daudé, le sam. 02 mars 2019 18:31:56 +0100, a ecrit: >> On 3/2/19 3:25 AM, Samuel Thibault wrote: >>> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> >>> --- >> >> I got: >> >> Applying: slirp: fix big/little endian conversion in ident protocol >> error: patch failed: slirp/tcp_subr.c:660 >> error: slirp/tcp_subr.c: patch does not apply >> >> Then noticed another slirp patch, applied first then this one succeed, >> so you missed: >> >> Based-on: <1551476756-25749-1-git-send-email-w...@wbowling.info> > > Oh, I didn't know about that one.
BTW 'Based-on' is a hint for the reviewers and automatic testing bots, telling "this commit is <based on> this other <series|patch>", and without applying the base it is unlikely this patch|series applies. It is not meant the git history, so for single commit we add it under the first '---' separator (automatically stripped out when applied) or for series we add it to the cover. I guess there are no doc about that hint in HACKING neither in the wiki, I remember the post where it was introduced: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01288.html Regards, Phil. > >> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > Thanks! > > Samuel >
