В сообщении от Saturday 02 March 2019 23:40:47 BALATON Zoltan написал(а):
[snip] > > On Sat, 2 Mar 2019, Andrew Randrianasulu wrote: > > Should I fix those? > > [...] > > > total: 14 errors, 2 warnings, 462 lines checked > > > > 0001-Re-applying-of-Freescale-PPC500-i2c-RTC-patch-writte.patch has style > > problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > Yes, patches submitted to the list should pass checkpatch otherwise they > will be rejected by automated build tests. These are simple to fix, just > add spaces as checkpatch suggests: (1 << 0) and so on. > > (It's better to keep the list cc-d on reply so others can also answer your > questions or correct my answers if I missed something which is not > possible if you reply to me off list.) Posted to list, arrived as https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00413.html I used (in specifically created branch) git reset origin git reset --hard git apply \ /home/guest/botva/src/src/qemu/0001-Re-applying-Freescale-PPC500-i2c-RTC-patch-written-b.patch rm hw/i2c/mpc_i2c.c (leftover from my previous attempt at commiting) again git apply \ /home/guest/botva/src/src/qemu/0001-Re-applying-Freescale-PPC500-i2c-RTC-patch-written-b.patch {now it applies cleanly) git add hw/i2c/mpc_i2c.c make ppc64-softmmu/qemu-system-ppc64 -M ppce500 -cpu e5500 -kernel /mnt/sdb1/PPC-img/linux-image-4.20.12-X1000_X5000/X5000_and_QEMU_e5500/uImage-4.20 -nographic git commit -a --author="Amit Singh Tomar <amit.to...@freescale.com>" git format-patch -s 20b084c4b1401b7f8fbc385649d48c67b6f43d44 scripts/checkpatch.pl 0001-Re-applying-Freescale-PPC-E500-i2c-RTC-patch.patch After this I created new message in Kmail and inserted 0001 file, edited it a bit more (adding patchwork link and mentioning fact I actually boot-tested patch), and then send out. Guess next time I better to add second "-s" to git format-patch, so first signed-off-by-line from original will be around too? Or ..lets wait what actual maintainers will say. > > Regards, > BALATON Zoltan