On Fri, Feb 08, 2019 at 11:00:23 +0000, Alex Bennée wrote: > > Emilio G. Cota <c...@braap.org> writes: > > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > Signed-off-by: Emilio G. Cota <c...@braap.org> > > --- > > target/i386/cpu.c | 2 +- > > target/i386/helper.c | 4 ++-- > > target/i386/svm_helper.c | 4 ++-- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index a37b984b61..35dea8c152 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -5678,7 +5678,7 @@ int x86_cpu_pending_interrupt(CPUState *cs, int > > interrupt_request) > > > > static bool x86_cpu_has_work(CPUState *cs) > > { > > - return x86_cpu_pending_interrupt(cs, cs->interrupt_request) != 0; > > + return x86_cpu_pending_interrupt(cs, cpu_interrupt_request(cs)) > > != 0; > > This is fine in itself but is there a chance of a race with the > env->eflags/hflags/hflags2 that x86_cpu_pending_interrupt deals with? > Are they only ever self vCPU references?
AFAICT they're all self-references; I have checked this via inspection and with helgrind. > Anyway: > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> Thanks! E.