-----Original Message----- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Friday, March 1, 2019 1:05 AM To: Zhang, Chen <chen.zh...@intel.com>; Li Zhijian <lizhij...@cn.fujitsu.com>; Zhang Chen <zhangc...@gmail.com>; Dr. David Alan Gilbert <dgilb...@redhat.com>; Juan Quintela <quint...@redhat.com>; zhanghailiang <zhang.zhanghaili...@huawei.com>; Markus Armbruster <arm...@redhat.com>; qemu-dev <qemu-devel@nongnu.org> Subject: Re: [PATCH V2 4/7] Migration/colo.c: Add new COLOExitReason to handle all failover state
On 2/28/19 10:55 AM, Zhang Chen wrote: > From: Zhang Chen <chen.zh...@intel.com> > > In this patch we add the processing state for COLOExitReason, because > we have to identify COLO in the failover processing state or failover > error state. In the way, we can handle all the failover state. > We have improved the description of the COLOExitReason by the way. > > Signed-off-by: Zhang Chen <chen.zh...@intel.com> > --- > migration/colo.c | 24 +++++++++++++----------- > qapi/migration.json | 15 +++++++++------ > 2 files changed, 22 insertions(+), 17 deletions(-) > > +++ b/qapi/migration.json > @@ -983,19 +983,22 @@ > ## > # @COLOExitReason: > # > -# The reason for a COLO exit > +# Describe the reason for COLO exit. > # > -# @none: no failover has ever happened. This can't occur in the -# > COLO_EXIT event, only in the result of query-colo-status. > +# @none: failover has never happened. This state does not occurred # > +in the COLO_EXIT event, only happened in the result of # > +query-colo-status. Grammar suggestion: This state does not occur in the COLO_EXIT event, and is only visible in the result of query-colo-status. OK~ I will fix it in next version. > # > -# @request: COLO exit is due to an external request > +# @request: COLO exit caused by an external request. > # > -# @error: COLO exit is due to an internal error > +# @error: COLO exit caused by an internal error. > +# > +# @processing: COLO in failover handling state. Missing a (since 4.0) tag. Maybe: @processing: COLO is currently handling a failover (since 4.0). Sure, thank you for your comments~ Thanks Zhang Chen -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
