Samuel Thibault <samuel.thiba...@gnu.org> writes: > Markus Armbruster, le lun. 04 mars 2019 07:44:34 +0100, a ecrit: >> Samuel Thibault <samuel.thiba...@ens-lyon.org> writes: >> > --- a/qapi/ui.json >> > +++ b/qapi/ui.json >> > @@ -1131,6 +1131,7 @@ >> > # @full-screen: Start user interface in fullscreen mode (default: off). >> > # @window-close: Allow to quit qemu with window close button (default: >> > on). >> > # @gl: Enable OpenGL support (default: off). >> > +# @charset: Font charset used by guest (default: CP437). >> >> Can you give brief rationale for defaulting to CP437? > > I have added to the commit message: > > “ > The default charset is made CP437 since that is the charset of the > hardware default VGA font. > ” > >> > @@ -492,6 +709,10 @@ static void curses_display_init(DisplayState *ds, >> > DisplayOptions *opts) >> > } >> > #endif >> > >> > + setlocale(LC_CTYPE, ""); >> >> General principles: any change to locale deserves prominent mention in >> the commit message. > > I have added to the commit message: > > “ > This also makes the curses backend set the LC_CTYPE locale to "" to > allow curses to emit wide characters. > ”
Your commit message amendments work for me. Thanks!
