Hi Eric, On Mon, Mar 04, 2019 at 12:40:50PM -0600, Eric Blake wrote: > On 3/4/19 12:09 PM, Sven Schnelle wrote: > > Signed-off-by: Sven Schnelle <sv...@stackframe.org> > > The commit header says "what" (good), but the commit body says nothing at > all (generally, it should say "why"). If you give your reviewers a reason > why it is good to use the new functions, it makes it easier to apply your > patch. > > Also, don't forget to send a 0/5 cover letter when sending a patch series; > you can have git do this for you with 'git config format.coverletter auto'. > https://wiki.qemu.org/Contribute/SubmitAPatch has more hints for improved > patch handling.
Thanks, will keep this in mind, sorry. Should i resend the series? Regards Sven
