On Fri, Mar 8, 2019 at 11:31 AM Laurent Desnogues
<laurent.desnog...@gmail.com> wrote:
>
> Hello,
>
> On Thu, Mar 7, 2019 at 6:09 PM Richard Henderson
> <richard.hender...@linaro.org> wrote:
[...]
> > +static CPAccessResult access_mte(CPUARMState *env, const ARMCPRegInfo *ri,
> > + bool isread)
> > +{
> > + int el = arm_current_el(env);
> > +
> > + if (el < 2 &&
> > + arm_feature(env, ARM_FEATURE_EL2) &&
> > + !(arm_hcr_el2_eff(env) & HCR_ATA)) {
> > + return CP_ACCESS_TRAP_EL2;
> > + }
>
> arm_hcr_el2_eff seems to be clearing HCR_ATA bit. I think it needs to
> be updated.
Forget that. I read it wrong and that's my test that is buggy!
Perhaps the comment about ARMv8.4 in arm_hcr_el2_eff should be updated?
Sorry,
Laurent
