On Fri, 8 Mar 2019 at 11:58, Gerd Hoffmann <kra...@redhat.com> wrote: > On Fri, Mar 08, 2019 at 10:31:20AM +0000, Peter Maydell wrote: > > I think in fact I have just broken in-tree builds with the > > Sphinx support patchset :-/ > > Great opportunity! Stop supporting in-tree build fixes a bug, > so this can be merged post soft-freeze.
Joking aside, this is quite tempting, because Sphinx simply does not support building into the same directory as its source documentation files. So we need to either: * create an ad-hoc build directory (eg docs/built) where Sphinx builds the docs to if we're doing an in-tree build, and have the 'make install' phase pull the docs out of there * declare in-tree builds to be no longer supported at all thanks -- PMM