Am 08.03.2019 um 13:28 hat Markus Armbruster geschrieben: > Laszlo Ersek <ler...@redhat.com> writes: > > This one has got to be one of the longest bike-shedding sessions! :) > > > > I'm fine with this patch, but I could suggest two improvements. > > > > (1) When blk_getlength() fails, we could format the negative error code > > returned by it into the error message. > > I can do that.
By using error_setg_errno(), I assume. Not throwing away error details is always good. > > (2) We could extract the common code to a new function in > > "hw/block/block.c". (It says "Common code for block device models" on > > the tin.) > > There's so much common code in these two files even before this patch... My understanding is that hw/block/block.c contains code that is potentially useful to all kinds of block devices, not random code that two specific similar devices happen to share. If we want to deduplicate some code in the flash devices, without any expectation that other devices will use it at some point, I'd rather create a new source file hw/block/pflash_common.c or something like that. Kevin
