CPU_QuadU isn't used on all targets, but there's no harm in defining the typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because softfloat-native doesn't have a float128 type. This avoids the need for every new target which uses CPU_QuadU to add itself to an #ifdef in what ought to be target-agnostic code.
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> --- Noticed this one as a result of the s390 support patches; seems like a minor but worthwhile cleanup to me... cpu-all.h | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 4cc445f..dc0f2f0 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -138,11 +138,10 @@ typedef union { uint64_t ll; } CPU_DoubleU; -#if defined(TARGET_SPARC) || defined(TARGET_S390X) +#if defined(CONFIG_SOFTFLOAT) typedef union { float128 q; -#if defined(HOST_WORDS_BIGENDIAN) \ - || (defined(__arm__) && !defined(__VFP_FP__) && !defined(CONFIG_SOFTFLOAT)) +#if defined(HOST_WORDS_BIGENDIAN) struct { uint32_t upmost; uint32_t upper; -- 1.7.1