On Mon, Apr 04, 2011 at 03:58:39PM +0400, Dmitry Eremin-Solenikov wrote: > On 4/3/11, Isaku Yamahata <yamah...@valinux.co.jp> wrote: > > On Sat, Apr 02, 2011 at 06:47:37PM +0400, Dmitry Eremin-Solenikov wrote: > >> On 4/2/11, Isaku Yamahata <yamah...@valinux.co.jp> wrote: > >> >> Have you verified that all bus devices have been qdevified since this > >> >> code has been added? I wouldn't bet it is the case. > >> > > >> > I think his analysis is valid. So how about the following patch. > >> > >> Could you please point me to an example of devices for which this check is > >> required. > > > > Although I don't have any example, I bet to not change the reset order. > > If you check all the devices, it's good. > > The question is which devices to check as lots of devices are already > converted to qdev. Is it correct that we should check only devices > which register a child bus with parent device set, and the thing that we > should check is the fact that the parent reset function also causes > the bus reset?
qbus whose parent is NULL, non-qdev devices and qdev devices which uses qemu_register_reset() instead of DeviceInfo::reset. -- yamahata
