On Mon, Mar 11, 2019 at 06:08:10PM +0100, Marc-André Lureau wrote: >Hi > >On Mon, Mar 11, 2019 at 9:34 AM Wei Yang <richardw.y...@linux.intel.com> wrote: >> >> Function object_new_with_propv already get the Type of the object, so we >> could leverage object_new_with_type here. >> >> [make check test pass] >> >> Signed-off-by: Wei Yang <richardw.y...@linux.intel.com> >> --- >> qom/object.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qom/object.c b/qom/object.c >> index 05a8567041..76d2f1eb2f 100644 >> --- a/qom/object.c >> +++ b/qom/object.c >> @@ -640,7 +640,7 @@ Object *object_new_with_propv(const char *typename, >> error_setg(errp, "object type '%s' is abstract", typename); >> return NULL; >> } >> - obj = object_new(typename); >> + obj = object_new_with_type(klass->type); >> >> if (object_set_propv(obj, &local_err, vargs) < 0) { >> goto error; >> -- >> 2.19.1 >> >> > >Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> >
Thanks :-) >-- >Marc-André Lureau -- Wei Yang Help you, Help me