On Thu, Mar 14, 2019 at 09:18:09AM -0700, Richard Henderson wrote: > On 3/14/19 8:57 AM, Daniel P. Berrangé wrote: > >> @@ -2070,6 +2078,7 @@ void qemu_init_vcpu(CPUState *cpu) > >> cpu->nr_cores = smp_cores; > >> cpu->nr_threads = smp_threads; > >> cpu->stopped = true; > >> + cpu->random_seed = qemu_seedrandom_thread_part1(); > >> > >> if (!cpu->as) { > >> /* If the target cpu hasn't set up any address spaces itself, > > It isn't clear that we should be needing these seeds in anything > > other than the TCG codepath. > > > > It's still possible to want to debug a program running under KVM. > > And while it was threaded into the v1 series this morning, I believe the > hw/misc/ RNG devices should use the new interface, which would enable that > debugging.
Yeah, now I see that hw/misc use case, this makes sense. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|