On 3/15/19 4:26 AM, Richard Henderson wrote:
> The random number is intended for use by the guest. As such, we should
> honor the -seed argument for reproducibility. Use the *_nofail routine
> instead of rolling our own error handling locally.
>
> Cc: qemu-...@nongnu.org
> Cc: Cédric Le Goater <c...@kaod.org>
> Cc: Andrew Jeffery <and...@aj.id.au>
> Cc: Joel Stanley <j...@jms.id.au>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
Thanks
Reviewed-by: Cédric Le Goater <c...@kaod.org>
Thanks,
C.
> ---
> hw/misc/aspeed_scu.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
> index c8217740ef..ab1e18ed4b 100644
> --- a/hw/misc/aspeed_scu.c
> +++ b/hw/misc/aspeed_scu.c
> @@ -16,7 +16,7 @@
> #include "qapi/visitor.h"
> #include "qemu/bitops.h"
> #include "qemu/log.h"
> -#include "crypto/random.h"
> +#include "qemu/guest-random.h"
> #include "trace.h"
>
> #define TO_REG(offset) ((offset) >> 2)
> @@ -157,14 +157,8 @@ static const uint32_t
> ast2500_a1_resets[ASPEED_SCU_NR_REGS] = {
>
> static uint32_t aspeed_scu_get_random(void)
> {
> - Error *err = NULL;
> uint32_t num;
> -
> - if (qcrypto_random_bytes((uint8_t *)&num, sizeof(num), &err)) {
> - error_report_err(err);
> - exit(1);
> - }
> -
> + qemu_guest_getrandom_nofail(&num, sizeof(num));
> return num;
> }
>
>
