On 3/15/19 11:42 AM, Philippe Mathieu-Daudé wrote: > Hi, > >>From my previous experience with the tests/ patches, I understood we > could still send PR that improve testing after soft freeze. > This series doesn't modify the QEMU binaries, it add EDK2 firmware blobs > in roms/ and rules to rebuild these roms. > These roms are useful for the ACPI tests introduced in commits > 09a274d82f and 503bb0b975a on the arm/virt board. > > There is 1 direct change: > > 1/ in the root Makefile, the 'make install' rule installs one new file: > - edk2-licenses.txt > > And there are 2 other changes which require user specific action: > > 2/ Set the environment variable 'INSTALL_BLOBS', the 'make install' rule > will install the firmware blobs and the firmware JSON descriptors > > 3/ a new 'efi' target rule in roms/Makefile > > I'm planning to send a PR for this series but I want to check first if > there is any issue with the current policy/rules. >
If this were during -rc2 or -rc3, our goal would be minimizing churn, and I would lean towards deferral. But for mere softfreeze before -rc0, and with your justification that this helps downstreams while provably being independent enough of the main binaries to be low risk, I agree with the idea of a PR. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
