On Mon, Mar 18, 2019 at 01:40:19PM +0000, Peter Maydell wrote: > Normally configure identifies the source path by looking > at the location where the configure script itself exists. > We also provide a --source-path option which lets the user > manually override this. > > There isn't really an obvious use case for the --source-path > option, and in commit 927128222b0a91f56c13a in 2017 we > accidentally added some logic that looks at $source_path > before the command line option that overrides it has been > processed. > > The fact that nobody complained suggests that there isn't > any use of this option and we aren't testing it either; > remove it. This allows us to move the "make $source_path > absolute" logic up so that there is no window in the script > where $source_path is set but not yet absolute. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > Since this is a "noticed while reading code" issue rather than > one that's actually causing a problem, it's probably 4.1 > material at this point.
I guess --source-path will still work in 4.0, as long as it is given a path that points to where 'configure' is. > Cc'ing Antonio since they also have a patch to configure > which this will affect. > --- > configure | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
