On Mon, 2019-03-18 at 02:31 -0700, Palmer Dabbelt wrote: > On Mon, 18 Mar 2019 01:39:46 PDT (-0700), pbonz...@redhat.com wrote: > > On 15/03/19 21:05, Alistair Francis wrote: > > > Set msi_nonbroken as true for the PLIC. > > > > > > According to the comment located here: > > > https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17faa8e6a01afe1f;hb=HEAD#l38 > > > the msi_nonbroken variable should be set to true even if they don't > > > support MSI. In this case that is what we are doing as we don't support > > > MSI. > > > > I can queue this patch, and add the "select MSI" to CONFIG_SIFIVE. > > Works for me. Thanks!
Just so we're on the same page, are you targeting this at 4.0.0? If it gets merged in the next few days I can probably get the corresponding libvirt patches in before our own freeze starts. It would be great if we could make it so guests created with QEMU 4.0.0 + libvirt 5.2.0 get PCI by default :) -- Andrea Bolognani / Red Hat / Virtualization