On 3/25/19 10:23 AM, Paolo Bonzini wrote: > I think you should, because moving it to obj-y would be a major headache > if we ever were to resurrect the multiarch patches by Peter C. > > That said, does cpu_neg really need env_neg and thus ArchCPU? Perhaps > you could: > > 1) define CPUTLB in terms of MAX_MMU_MODES (12) instead of NB_MMU_MODES > > 2) assert that > > offsetof(ArchCPU, env) - offsetof(ArchCPU, neg) == > sizeof(CPUNegativeOffsetState)
This doesn't work, since CPUTLB depends on target_ulong. I think I'll go back to a pointer from CPUState to icount_decr, but clean up how this and CPUState->env_ptr are initialized. r~
