Patchew URL: https://patchew.org/QEMU/20190403125055.26564-1-jbi.oct...@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190403125055.26564-1-jbi.oct...@gmail.com Subject: [Qemu-devel] [PATCH 0/5] target/mips/cpu: errors and warnings coding style cleanup Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190319144013.26584-2-pbonz...@redhat.com -> patchew/20190319144013.26584-2-pbonz...@redhat.com t [tag update] patchew/20190401154028.GA10574@erokenlabserver -> patchew/20190401154028.GA10574@erokenlabserver * [new tag] patchew/20190403125055.26564-1-jbi.oct...@gmail.com -> patchew/20190403125055.26564-1-jbi.oct...@gmail.com Switched to a new branch 'test' 45a6212b4a target/mips: wrap line into multiple lines to to fix checkpatch errors 71f1867094 target/mips: remove space to fix checkpatch errors 68b4463c72 target/mips: replace indentation with space to fix checkpatch errors b265859837 target/mips: realign comments to fix checkpatch warnings fbf61f7591 target/mips: add space to fix checkpatch errors === OUTPUT BEGIN === 1/5 Checking commit fbf61f759167 (target/mips: add space to fix checkpatch errors) ERROR: line over 90 characters #40: FILE: target/mips/cpu.h:74: +#define SET_FP_COND(num, env) do { ((env).fcr31) |= ((num) ? (1 << ((num) + 24)) : (1 << 23)); } while (0) ERROR: line over 90 characters #41: FILE: target/mips/cpu.h:75: +#define CLEAR_FP_COND(num, env) do { ((env).fcr31) &= ~((num) ? (1 << ((num) + 24)) : (1 << 23)); } while (0) ERROR: line over 90 characters #50: FILE: target/mips/cpu.h:80: +#define SET_FP_CAUSE(reg, v) do { (reg) = ((reg) & ~(0x3f << 12)) | ((v & 0x3f) << 12); } while (0) ERROR: line over 90 characters #51: FILE: target/mips/cpu.h:81: +#define SET_FP_ENABLE(reg, v) do { (reg) = ((reg) & ~(0x1f << 7)) | ((v & 0x1f) << 7); } while (0) ERROR: line over 90 characters #52: FILE: target/mips/cpu.h:82: +#define SET_FP_FLAGS(reg, v) do { (reg) = ((reg) & ~(0x1f << 2)) | ((v & 0x1f) << 2); } while (0) total: 5 errors, 0 warnings, 36 lines checked Patch 1/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/5 Checking commit b265859837f5 (target/mips: realign comments to fix checkpatch warnings) ERROR: trailing whitespace #66: FILE: target/mips/cpu.h:995: + * this from three bits to two. $ ERROR: trailing whitespace #89: FILE: target/mips/cpu.h:1109: +/* $ total: 2 errors, 0 warnings, 71 lines checked Patch 2/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/5 Checking commit 68b4463c727f (target/mips: replace indentation with space to fix checkpatch errors) 4/5 Checking commit 71f1867094cf (target/mips: remove space to fix checkpatch errors) 5/5 Checking commit 45a6212b4ad9 (target/mips: wrap line into multiple lines to to fix checkpatch errors) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190403125055.26564-1-jbi.oct...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com