> -----Original Message----- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, April 4, 2019 9:43 AM > To: Zhang, Chen <chen.zh...@intel.com> > Cc: Dr. David Alan Gilbert <dgilb...@redhat.com>; qemu-dev <qemu- > de...@nongnu.org>; John Snow <js...@redhat.com>; Fam Zheng > <f...@euphon.net> > Subject: Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function > test_and_change_bit() > > On Sat, 30 Mar 2019 at 03:09, Zhang Chen <chen.zh...@intel.com> wrote: > > > > From: Zhang Chen <chen.zh...@intel.com> > > > > In current codes we use change_bit() to finish the job. > > > > Signed-off-by: Zhang Chen <chen.zh...@intel.com> > > --- > > include/qemu/bitmap.h | 1 - > > include/qemu/bitops.h | 15 --------------- > > 2 files changed, 16 deletions(-) > > Do we gain anything by removing this function? IIRC these functions are all > borrowed from the Linux kernel, so keeping the same API as the kernel does > would make sense to me, even if we happen not to use all of it right now. >
Hi Peter, OK, I agree with you. But another question are the bitmap.h and bitops.h lack of maintenance. Please look at this patch: [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field Do you have any comments? Thanks Zhang Chen > thanks > -- PMM
