On 4/9/19 1:30 PM, Richard Henderson wrote: > On 4/9/19 1:15 PM, Richard Henderson wrote: >> On 2/13/19 3:46 AM, Laurent Vivier wrote: >>> In fact it happens with sid, with ppc64 too, but not with m68k and sh4. >>> >>> And only with "unshare --pid --fork". >>> >>> Without "unshare", the result is: >>> >>> Unsupported ioctl: cmd=0x80047476 >>> bash: cannot set terminal process group (11507): Function not implemented >>> bash: no job control in this shell >>> Unsupported ioctl: cmd=0x80087467 >>> Unsupported ioctl: cmd=0x80087467 >>> Unsupported ioctl: cmd=0x802c7415 >> >> I'm just now getting back to this, and cannot replicate the issue > > ... Oh nevermind. I should be expecting no "unsupported" at all, since that's > what we get with master.
The cause is that "cmd" accidentally changed from "int" in the do_ioctl parameter list to "abi_ulong" as a local variable in impl_ioctl. This caused a table lookup failure on any ioctl with bit 31 set, for 64-bit guests. r~
