On 10/04/2019 08.07, Thomas Huth wrote: > On 09/04/2019 21.46, Stefan Weil wrote: >> On 05.04.19 11:16, Philippe Mathieu-Daudé wrote: >>> On 4/5/19 11:02 AM, Daniel P. Berrangé wrote: >>>> On Fri, Apr 05, 2019 at 10:47:54AM +0200, Philippe Mathieu-Daudé wrote: >>>> Do the various crashes that you illustrate in that cover letter >>>> still exist today ? If so, 2 years of continued brokenness with no >>>> fixes would reinforce the the view that it is time to remove TCI >>>> from the codebase. >>> >>> Or find a maintainer and add tests... >> >> Thank you for CC'ing me. I could not spend much of my free time for QEMU >> last year and typically will miss important messages on the list unless >> my address is explicitly given. Nevertheless I still feel responsible >> for TCI, and I am also listed as maintainer in MAINTAINERS. > > That's great, good to know that you're still interested in TCI! ... but > I think one of the main problems is still that we completely lack test > coverage for TCI - the code always is in danger to bit-rot if it is not > tested by default. > > I could maybe have a try to add some test to our .gitlab-ci.yml file ... > if you or somebody else could add one to .travis.yml, that would be > great. Something like: > > - ./configure --enable-tcg-interpreter > --target-list=alpha-softmmu,ppc64-softmmu,i386-softmmu,sparc-softmmu,microblaze-softmmu,moxie-softmmu,arm-softmmu,hppa-softmmu > - make > - make tests/boot-serial-test > - QTEST_QEMU_BINARY="alpha-softmmu/qemu-system-alpha" > ./tests/boot-serial-test > - QTEST_QEMU_BINARY="ppc64-softmmu/qemu-system-ppc64" > ./tests/boot-serial-test > - ...
Additionally, I think it should be possible to compile with the x86_64-linux-user target and then to run "make check-tcg" ... however, that currently crashes with: TODO qemu/tcg/tci.c:859: tcg_qemu_tb_exec() qemu/tcg/tci.c:859: tcg fatal error qemu: uncaught target signal 11 (Segmentation fault) - core dumped Thomas