On 04/10/19 06:57, Philippe Mathieu-Daudé wrote: > In commit 1cab464136b4 we incorrectly described the > EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS > options to the EDK2 build tools, but it only expands > the CFLAGS (not to the CPPFLAGS). > Update the description to be more accurate. > > Reported-by: Laszlo Ersek <ler...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > roms/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/roms/Makefile b/roms/Makefile > index 1ff78b63bb3..d7fd6025e7c 100644 > --- a/roms/Makefile > +++ b/roms/Makefile > @@ -120,8 +120,8 @@ build-efi-roms: build-pxe-roms > $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \ > $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets)) > > -# Build scripts can pass compiler/linker flags to the EDK2 build tools > -# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and > +# Build scripts can pass compiler/linker flags to the EDK2 > +# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and > # EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables. > # > # Example: >
Reviewed-by: Laszlo Ersek <ler...@redhat.com> Please noone submit a pull request with this patch (for 4.1) until my edk2 bundling series is merged; as this one will likely introduce another contextual conflict, and I'd *really* like to avoid another rebase on my end, due to such an issue. Thanks! Laszlo
