On Wed, 10 Apr 2019 at 17:40, Max Reitz <mre...@redhat.com> wrote: > > On 10.04.19 18:39, Eric Blake wrote: > > On 4/10/19 11:29 AM, Max Reitz wrote: > >> tmpfs does not support O_DIRECT. Detect this case, and skip flipping > >> @direct if the filesystem does not support it. > >> > >> Fixes: bf3e50f6239090e63a8ffaaec971671e66d88e07 > >> Signed-off-by: Max Reitz <mre...@redhat.com> > >> --- > >> tests/qemu-iotests/245 | 10 ++++++++-- > >> 1 file changed, 8 insertions(+), 2 deletions(-) > > > > Are you trying to get this in 4.0-rc3? (As a test, it has no bearing on > > the actual binaries; fewer testsuite failures are nice if we squeeze it > > in, but at the same time it is not enough to delay the release if it > > does not get fixed until 4.1). > > > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > If there are other patches for rc3, we could take this as well. But > there is no point in making a pull request just for this.
rc3 has been tagged already, I'm afraid. rc4 will be only if something release-critical crops up. thanks -- PMM