On 4/8/19 8:51 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.04.2019 6:05, Eric Blake wrote: >> Previous commits have mentioned that our NBD server still sends >> unaligned fragments when an active layer with large advertised minimum >> block size is backed by another layer with a smaller block >> size. Expand the test to actually cover this scenario, by using qcow2 >> encryption (which forces 512-byte alignment) with an unaligned raw >> backing file. >> >> The test passes, but only because the client side works around the >> server's non-compliance; if you repeat the test manually with tracing >> turned on, you will see the server sending a status for 1000 bytes >> data then 1048 bytes hole, which is not aligned. But reverting commit >> 737d3f5244 shows that it is indeed the client working around the bug >> in the server. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> > > Oops, 241 fails for me: > > -WARNING: Image format was not specified for > '/home/eblake/qemu/tests/qemu-iotests/scratch/t.raw' and probing guessed raw. > +WARNING: Image format was not specified for > '/work/src/qemu/eric/tests/qemu-iotests/scratch/t.raw' and probing guessed > raw. > > We forget to filter output :(
The filter bug is pre-existing; separate patch for that is now posted. > > Tested-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> I saw this email before -rc3, but thought I had only introduced the problem in this patch which I omitted from my rc3 pull request. Oh well, the actual break in iotests came earlier; if there's an -rc4 for other reasons, we'll get the test fixed then. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature