Looks fine to me. I suppose if I had written it, I would have included more comments and/or #define's to make some bits more obvious (all the magic constants look a bit scary until you read the Intel manual), but nevermind that.
I guess the other remaining part now is extending risugen to actually generate the test blobs. -Jan On 4/9/19 2:54 AM, Richard Henderson wrote: > The state expected for a given test must be specifically requested > with the --xfeatures=mask command-line argument. This is recorded > with the saved state so that it is obvious if the apprentice is given > a different argument. Any features beyond what are present on the > running cpu will read as zero. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > > More fiddling. This puts an --xfeature=mask argument on the command > line that must agree the test case being tested. This requires somewhat > deeper knowledge of the cpu than I would otherwise like, but I cannot > disconnect this knowledge with that required for writing the test in > the first place. > > Usual values for mask are 3 (SSE), 7 (AVX), 0xe7 (AVX512), and well > documented in the "Managing state using the XSAVE feature set" > chapter of the Intel architecture manual. > > Thoughts? > > > r~
signature.asc
Description: OpenPGP digital signature
