On 12/04/19 10:19, Erik Skultety wrote: >> Since this field is not specific to guest configuration, I don't think >> it belongs in query-sev-capabilities; QEMU does not care about >1 guest. > Neither pdh nor cert-chain are specific to the guest config.
Sort of, they are required to start a guest, aren't they? But the number of guests is irrelevant. > I see why this > should be better suited for query-sev, the same goes for libvirt - I think we > shouldn't have gone with reporting the SEV platform caps in domain > capabilities, > we should have IMHO report it both in the host capabilities (platform specific > stuff) and in domain capabilities to indicate that both libvirt and QEMU > support the SEV feature. Having said that, we have a precedent which I think > we might be better off with following rather than splitting the information > among multiple commands. For Libvirt, sure. But I think this doesn't belong in QEMU at all. Libvirt should just use CPUID. Paolo
