Hi Li,
The patch title is not very descriptive, maybe "allow 64-bit access"
On 4/20/19 6:14 PM, Li Qiang wrote:
> The edu spec said, the MMIO area can be accessed by 8 bytes.
or 64-bit...
> However currently the 'max_access_size' is not so the MMIO
> access dispatch can only access 4 bytes one time. This patch
32-bit
> fixes this to respect the spec.
>
> Notice: here the 'min_access_size' is not a must, I set this
> for completement.
Which one? valid/impl? I think you can drop this comment from the commit
description.
>
> Signed-off-by: Li Qiang <liq...@163.com>
> ---
> hw/misc/edu.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index 91af452c9e..65fc32b928 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -289,6 +289,15 @@ static const MemoryRegionOps edu_mmio_ops = {
> .read = edu_mmio_read,
> .write = edu_mmio_write,
> .endianness = DEVICE_NATIVE_ENDIAN,
> + .valid = {
> + .min_access_size = 4,
Per the spec, this is correct.
> + .max_access_size = 8,
Correct.
> + },
> + .impl = {
> + .min_access_size = 4,
OK.
> + .max_access_size = 8,
Correct.
> + },
> +
> };
>
> /*
>
With title/description updated:
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
