On 23.04.19 22:26, Richard Henderson wrote: > On 4/23/19 12:15 PM, David Hildenbrand wrote: >> On 20.04.19 09:34, Richard Henderson wrote: >>> Based-on: tcg-next, which at present is only tcg_gen_extract2. >>> >>> The dupm patches have been on list before, with a larger context >>> of supporting tcg/ppc. The rest of the set was written to support >>> David's s390 vector patches. In particular: >>> >>> (1) Add vector absolute value. >>> (2) Add vector shift by non-constant scalar. >>> (3) Add vector shift by vector. >>> (4) Add vector select. >> >> Remind me, is this for VECTOR SELECT on s390x where we already added a >> vector variant? At least VECTOR SELECT on s390x works on bit, not >> element granularity. > > > No, this was more for implementing _vec helpers, where we can > reasonably use element granularity (since that's all x86 has). > > I thought about adding a bitsel alongside cmpsel, to work on > bits like this, but haven't yet. >
Makes sense, thanks! -- Thanks, David / dhildenb
