On 4/29/19 9:17 AM, Peter Maydell wrote:
>> + struct elf_phdr *eppnt = phdr + i;
>> +
>> + switch (eppnt->p_type) {
>> + case PT_LOAD:
>> + {
>
> I think you have an extra layer of indent here that we usually
> don't do for switch statement cases.
No, that indent is exactly right for a compound statement
not associated with an if/while/whatnot.
> #define GNU0_MAGIC const_le32('G' | 'N' << 8 | 'U' << 16)
>
> and then you can avoid the #ifdef HOST_WORDS_BIGENDIAN?
Sure.
r~
