On Wed, Apr 24, 2019 at 03:10:49PM -0300, Eduardo Habkost wrote: > On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: > > On 23/04/2019 23.22, Eduardo Habkost wrote: > > > This series adds machine type deprecation information to the > > > output of the `query-machines` QMP command. With this, libvirt > > > and management software will be able to show this information to > > > users and/or suggest changes to VM configuration to avoid > > > deprecated machine types. > > > > > > Eduardo Habkost (3): > > > qapi: SupportStatusInfo struct > > > machine: Use SupportStatusInfo for deprecation info > > > qmp: Add deprecation information to query-machines > > > > > > qapi/common.json | 24 ++++++++++++++++++++++++ > > > qapi/misc.json | 5 ++++- > > > include/hw/boards.h | 7 ++++--- > > > hw/i386/pc_piix.c | 4 +++- > > > hw/ppc/prep.c | 4 +++- > > > vl.c | 19 +++++++++++++++---- > > > tests/acceptance/query_machines.py | 27 +++++++++++++++++++++++++++ > > > 7 files changed, 80 insertions(+), 10 deletions(-) > > > create mode 100644 tests/acceptance/query_machines.py > > > > Good idea, but some questions come to my mind: > > > > - What about devices? IIRC Gerd wrote a patch series last year that does > > something similar for devices... It would be good to synchronize the > > work, so that we do not have two completely interfaces between devices > > and machines here in the end... > > My plan is to support this on devices, too. I even had a version > where documentation of SupportStatusInfo mentioned device types, > but I decided to leave that out until we actually implement a > device deprecation info API.
We need it on CPU models, and on CPU features too potentially. Essentially we should consider it applicable to anything we report in QMP. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|