Patchew URL: https://patchew.org/QEMU/20190430172236.14325-1-paul.c....@intel.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190430172236.14325-1-paul.c....@intel.com Subject: [Qemu-devel] [PATCH] Introduce SnowRidge CPU model === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190430172236.14325-1-paul.c....@intel.com -> patchew/20190430172236.14325-1-paul.c....@intel.com Switched to a new branch 'test' 4a4ca68c21 Introduce SnowRidge CPU model === OUTPUT BEGIN === ERROR: code indent should never use tabs #37: FILE: target/i386/cpu.c:2675: +^I /* missing: CPUID_PN CPUID_IA64 */$ ERROR: spaces required around that '|' (ctx:VxW) #39: FILE: target/i386/cpu.c:2677: + CPUID_FP87 | CPUID_VME | CPUID_DE| CPUID_PSE | ^ WARNING: Block comments use a leading /* on a separate line #43: FILE: target/i386/cpu.c:2681: + CPUID_PAT | CPUID_PSE36 | /* CPUID_PN | */ CPUID_CLFLUSH | WARNING: line over 80 characters #52: FILE: target/i386/cpu.c:2690: + CPUID_EXT_SSE42 | CPUID_EXT_X2APIC | CPUID_EXT_MOVBE | CPUID_EXT_POPCNT | ERROR: line over 90 characters #80: FILE: target/i386/cpu.c:2718: + CPUID_7_0_EDX_ARCH_CAPABILITIES | CPUID_7_0_EDX_SPEC_CTRL_SSBD, /* missing bit 30 */ WARNING: Block comments use a leading /* on a separate line #81: FILE: target/i386/cpu.c:2719: + /* Missing: XSAVES (not supported by some Linux versions, WARNING: Block comments should align the * on each line #82: FILE: target/i386/cpu.c:2720: + /* Missing: XSAVES (not supported by some Linux versions, + * including v4.1 to v4.12). total: 3 errors, 4 warnings, 72 lines checked Commit 4a4ca68c21ba (Introduce SnowRidge CPU model) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190430172236.14325-1-paul.c....@intel.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
