On Tue, Apr 30, 2019 at 10:36:18PM +0000, Wei Yang wrote: [...] > >> +#ifdef CONFIG_LINUX > >> +#include <linux/mman.h> > >> +#endif /* CONFIG_LINUX */ > >> + > >> +#ifndef MAP_SYNC > >> +#define MAP_SYNC 0 > >> +#endif > >> +#ifndef MAP_SHARED_VALIDATE > >> +#define MAP_SHARED_VALIDATE 0 > >> +#endif > > > >Why would we need this, if we added copies of mman.h to > >linux-headers? > > This is reported by Stefan. > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg612168.html
Stefan, did you hit a build failure, or it was just theoretical? linux-headers/*/mman.h is updated by "linux-headers: add linux/mman.h" (commit 8cf108c5d159). If the build really fails, something else is broken in our build system. -- Eduardo
