On Mon, Apr 29, 2019 at 01:58:46PM +0100, Peter Maydell wrote: > On Mon, 29 Apr 2019 at 13:28, Stefan Hajnoczi <stefa...@redhat.com> wrote: > > > > On Fri, Apr 26, 2019 at 12:45:37PM +0100, Peter Maydell wrote: > > I was going to add a function to check kernel_filename and the presence > > of -device loader. Then each machine type init function would call the > > function with flags indicating which modes are allowed: > > > > /* Allow both -kernel and -device loader */ > > check_kernel_loaded(KERNEL_CMDLINE | KERNEL_LOADER); > > > > /* Allow only -kernel */ > > check_kernel_loaded(KERNEL_CMDLINE); > > > > /* Allow only -device loader */ > > check_kernel_loaded(KERNEL_LOADER); > > Every machine should permit -device loader: the point > of it is that it is entirely generic and works the same > way on every machine.
It seems every person has a slightly different preference :). Can we reach a consensus? 1. Should QEMU print a readable error message when launched without a kernel? If yes: 2. What checks are sensible? Stefan
signature.asc
Description: PGP signature
