On 5/1/19 5:38 PM, Richard Henderson wrote: > About half of the values to which CPU_CFLAGS is set > have multiple space separated arguments. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > configure | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/configure b/configure > index 234cb929ca..16bd4375d1 100755 > --- a/configure > +++ b/configure > @@ -1543,37 +1543,37 @@ case "$cpu" in > CPU_CFLAGS="-m64" > LDFLAGS="-m64 $LDFLAGS" > cross_cc_ppc64=$cc > - cross_cc_cflags_ppc64=$CPU_CFLAGS > + cross_cc_cflags_ppc64="$CPU_CFLAGS"
Makes no difference semantically (bare variable assignments are not subject to word splitting or globbing, so the quotes don't change the result); the only reason to change this is for consistency (using quotes everywhere is easier to remember, whether or not they are in a context that matter). So I'm okay whether this patch goes in or is omitted. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
