On 03/05/2019 02.36, Cao Jiaxi wrote: > The win2qemu[] is supposed to be the conversion table to convert between > STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga. > > But it was incorrectly written that it forces to set a GuestDiskBusType > value to STORAGE_BUS_TYPE, which generates an enum conversion warning in > clang. > > Signed-off-by: Cao Jiaxi <driver1...@foxmail.com> > --- > qga/commands-win32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index d40d61f605..6b67f16faf 100644 > --- a/qga/commands-win32.c > +++ b/qga/commands-win32.c > @@ -457,7 +457,7 @@ void qmp_guest_file_flush(int64_t handle, Error **errp) > > #ifdef CONFIG_QGA_NTDDSCSI > > -static STORAGE_BUS_TYPE win2qemu[] = { > +static GuestDiskBusType win2qemu[] = { > [BusTypeUnknown] = GUEST_DISK_BUS_TYPE_UNKNOWN, > [BusTypeScsi] = GUEST_DISK_BUS_TYPE_SCSI, > [BusTypeAtapi] = GUEST_DISK_BUS_TYPE_IDE,
Reviewed-by: Thomas Huth <th...@redhat.com>