On 10/12/2018 17:56, Peter Maydell wrote:
This patchset converts the m68k target from the deprecated
unassigned_access hook to the new transaction_failed hook.
It's RFC for a couple of reasons:
  * it's untested, since I don't have an m68k test image
  * the second patch just makes "bus error while trying to
    read page tables" be treated as a page fault, when it
    should probably cause a fault reporting it as a bus error
    of some kind
  * I don't understand why the old unassigned_access hook
    set the ATC bit in the MMU SSW, since the docs I have say
    this should be set if the fault happened during a table
    search, but cleared if it's just an ordinary bus-errored
    data or insn access. Probably this is a pre-existing bug?

I think you're right. It must be cleared on bus error.

Thanks,
Laurent

Reply via email to